-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GraphiQL page to the latest version #1889
Update GraphiQL page to the latest version #1889
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
- Coverage 98.20% 98.19% -0.01%
==========================================
Files 161 160 -1
Lines 6405 6379 -26
Branches 1205 1203 -2
==========================================
- Hits 6290 6264 -26
Misses 58 58
Partials 57 57 |
Thanks for adding the Here's a preview of the changelog: This release updates the built-in GraphiQL version to version 2.0, Here's the preview release card for twitter: Here's the tweet text:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I've only added a comment about the favicon.
Would be willing to spend a bit of time trying to add the explorer again? I think it is pretty useful :)
I have now added in the GraphiQL Explorer using OneGraph's package (see here for repo and here for the example I based it off) I'm ngl doing it with CDN based packages provided some limitations and challenges but I think I got it working pretty well 😅 See below for how it looks PS: I seem to have broken Windows builds somehow with my file encoding 🙈 |
889dd9e
to
c438944
Compare
@MattExact this seems to be slightly broken for me: it doesn't get the field for the people field, is this something you can reproduce as well? |
@MattExact there's version 2 of GraphiQL coming out soon, maybe we can wait for that, I tried a pre-release on this PR and it seems to work: it doesn't have the same explorer capabilities yet, but it is planned, there's even a prototype here: https://jonathanawesome.github.io/graphiql-v2-prototype/?mode=preview&story=reference--reference |
@patrick91 Apologies I forgot to reply to your previous comment, I was able to replicate your problem. I would be inclined to wait for v2, and hopefully they have decent support for using GraphiQL with a CDN 🤞 |
No worries! I'll update this PR with the beta so we have it ready for the release 😌 |
Any news on this? |
we are still waiting for the release of GraphiQL v2 😊 |
Is it not possible to use a preview version? It seems like it will be a while before there is a release or beta. |
I think the release should happen soon, see: https://discord.com/channels/625400653321076807/966768858402816020/1001946875093602476 I'd prefer to release an update with a stable version of GraphiQL 😊 |
GraphiQL 2 has been released! I'll see if I can update this PR this week :) I need to figure out how to get the explorer working via the CDN version of GraphiQL. Ref: https://github.com/graphql/graphiql/blob/main/examples/graphiql-explorer/src/App.tsx |
I think we'll be able to update when this PR is released 😊 graphql/graphiql#2699 |
seems there's a couple of small issues, as soon as they are fixed I'll merge this PR 😊 |
also I need to reintroduce support for websockets 😊 |
8fe81b1
to
6f8bc3a
Compare
/pre-release |
Pre-release👋 Releasing commit [a43d9bf] to PyPi as pre-release! 📦 |
Pre-release👋 Pre-release 0.127.0.dev.1661797666 [a43d9bf] has been released on PyPi! 🚀 poetry add strawberry-graphql==0.127.0.dev.1661797666 |
cb08ead
to
1565e78
Compare
The following CSS needs to be added to make the explorer scrollable and fully display the "Add new" below. .doc-explorer-contents {
overflow-y: hidden !important;
}
.docExplorerWrap {
width: unset !important;
min-width: unset !important;
} |
Description
Updated the GraphiQL page to use
[email protected]
(was previously using[email protected]
).This is necessary because older versions of GraphiQL have a Cross-site Scripting vulnerability (see snyk and the GraphiQL docs).
I have updated the file to be based upon the CDN example provided by the GraphiQL team.
I have made a couple of modifications to the file to bring in line with our current GraphiQL page:
There are a couple of changes to the interface due to the updated version, most notably the loss of the "Explorer".
It may be possible to add this back in via the graphiql-explorer package.
Types of Changes
Issues Fixed or Closed by This PR
Checklist