Model v5 #7
Merged
Model v5 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Works on Darwin after some configuration. Where should we add the following instructions?
Darwin requires you to export the lib and include directories:
export LIBRARY_PATH=/usr/local/lib
export C_INCLUDE_PATH=/usr/local/include
And rebuild the dynamic linker cache:
sudo update_dyld_shared_cache
|
@cpoile Thanks. Updated the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to support the new Silero VAD model v5. Will push a new version after this is merged since it's technically a breaking change.
Also added some basic CI.
@cpoile I'd appreciate it if you could check that the tests pass on your Mac.