Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add .rm and .rmSync to fs methods #362

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

alienzhou
Copy link
Contributor

.rm and .rmSync were added in Node.js v14.14.0.

Although they has been implemented in memfs, they are not binded when calling createFsFromVolume().

// Bind FS methods.
for (const method of fsSyncMethods) if (typeof vol[method] === 'function') fs[method] = vol[method].bind(vol);
for (const method of fsAsyncMethods) if (typeof vol[method] === 'function') fs[method] = vol[method].bind(vol);

https://github.com/streamich/memfs/blob/dd3828afa053af441d37e92a8d449f6782554458/src/index.ts#L38-L40

These methods are not in fsSyncMethods and fsAsyncMethods now.

@G-Rath G-Rath changed the title feat(list): add .rm and .rmSync to fs methods feat: add .rm and .rmSync to fs methods Jul 12, 2022
@G-Rath G-Rath changed the title feat: add .rm and .rmSync to fs methods fix: add .rm and .rmSync to fs methods Jul 12, 2022
@G-Rath G-Rath merged commit 2f1a49f into streamich:master Jul 12, 2022
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
## [1.0.4](v1.0.3...v1.0.4) (2023-06-01)

### Bug Fixes

* add .rm and .rmSync to fs methods ([#362](#362)) ([2f1a49f](2f1a49f))
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants