Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/error.rs causes typescript builds to break #263

Closed
meeroslav opened this issue Nov 29, 2018 · 1 comment
Closed

internal/error.rs causes typescript builds to break #263

meeroslav opened this issue Nov 29, 2018 · 1 comment
Labels
released

Comments

@meeroslav
Copy link

Build script tsc -p . && cpy src/internal lib/internal copies also the error.ts file which subsequently gets then published causing the typescript projects to break.

Script could be enhanced with:

tsc -p . && cpy src/internal lib/internal && rm lib/internal/error.ts
meeroslav added a commit to meeroslav/memfs that referenced this issue Nov 29, 2018
@meeroslav
Update script to omit copying of errors.ts
4f5eac9 
fixes streamich#263
pizzafroide added a commit that referenced this issue Nov 29, 2018
@pizzafroide
chore(build): remove unnecessary copy of src/internal
0a9cbc1 
Fixes #263
@pizzafroide pizzafroide mentioned this issue Nov 29, 2018
Merged
streamich pushed a commit that referenced this issue Nov 29, 2018
@pizzafroide @streamich
fix: don't copy legacy files into dist
ab8ffbb 
* chore(build): remove unnecessary copy of src/internal

Fixes #263

* chore: 🤖 update yarn.lock
streamich pushed a commit that referenced this issue Nov 29, 2018
@semantic-release-bot
chore(release): 2.14.1 [skip ci]
4a3caa5 
## [2.14.1](v2.14.0...v2.14.1) (2018-11-29)

### Bug Fixes

* don't copy legacy files into dist ([ab8ffbb](ab8ffbb)), closes [#263](#263)
@streamich
Copy link
Owner

🎉 This issue has been resolved in version 2.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meeroslav @streamich