fix: support directories named __proto__
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
G-Rath
requested changes
Sep 12, 2023
Comment on lines
63
to
70
| let isDirectory = false; | ||
| try { | ||
| isDirectory = vol.statSync('/__proto__').isDirectory(); | ||
| } catch { | ||
| // ignore | ||
| } | ||
|
|
||
| expect(isDirectory).toBe(true); |
There was a problem hiding this comment.
I think it would be better to just let the error throw, since if this test fails because of that the first thing you're going to want to do is see that error
There was a problem hiding this comment.
I was copying the test spec from existing test cases. But yes, throwing the error does make sense.
There was a problem hiding this comment.
Done in 2394a8e (#945).
G-Rath
approved these changes
Sep 15, 2023
G-Rath
changed the title
children plain object with Map__proto__
|
🎉 This PR is included in version 4.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #938.
Linkis currently using a plain object (Record<string, Link>) to hold thechildreninformation. The PR repalces the plain object withMap.