feat(volume): implement readv and writev #946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses four missing features (plus two not mentioned there) listed in #735.
readv
,writev
,readvSync
andwritevSync
toVolume
.FileHandle#readv
andFileHandle#writev
.As a bonus, I modified the existing
read
implementation:read
so thatposition
can receivenull
, which better aligns to thereadv
signature. In fact, passingnull
was already working expect that TypeScript complained about that.-1
toposition
is now equivalent to passingnull
for better compatibility with Node.I also modified the existing
write
implementation:-1
toposition
is now equivalent to passingnull
for better compatibility with Node.