Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored CLI client #476

Merged
merged 2 commits into from
May 18, 2024
Merged

Refactored CLI client #476

merged 2 commits into from
May 18, 2024

Conversation

merlimat
Copy link
Collaborator

  • Simplified commands to do just one single put/get/delete operation
  • Allow to print content in hex dump format
  • Switched tests to use mocked Oxia client and verifying the right arguments are passed depending on the CLI

@merlimat merlimat merged commit 62778f3 into streamnative:main May 18, 2024
5 checks passed
@merlimat merlimat deleted the refactored-client-cli branch May 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao Awaiting requested review from mattisonchao mattisonchao is a code owner

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merlimat