Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): delete duplicated callback #550

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

mattisonchao
Copy link
Member

Motivation

In the old logic, there's the wrong usage for iteration is as follow:

for it.Next() {
	err := updateOperationCallback.OnDelete(batch, it.Key())
	if err != nil {
		return errors.Wrap(multierr.Combine(err, it.Close()), "oxia db: failed to delete range")
	}
}

After pr #544, we already added a deleteRange callback. Therefore, we can delete this wrong logic directly.

@merlimat merlimat merged commit c76bb3a into main Oct 10, 2024
7 checks passed
@merlimat merlimat deleted the db.fix.callback.duplication branch October 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants