This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fix: use pointer for struct field so the default value from unmarshal is nil #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangpengcheng
changed the title
zerbitx
approved these changes
Jul 18, 2023
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
… is nil (streamnative/pulsar-admin-go#36) Use pointer for struct field so the default value from unmarshal is nil Co-authored-by: Neng Lu <[email protected]>
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
… is nil (streamnative/pulsar-admin-go#36) Use pointer for struct field so the default value from unmarshal is nil Co-authored-by: Neng Lu <[email protected]>
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
… is nil (streamnative/pulsar-admin-go#36) Use pointer for struct field so the default value from unmarshal is nil Co-authored-by: Neng Lu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #TODO
Motivation
Modifications
ProducerConfig,CryptoConfigandBatchSourceConfigRetainKeyOrderingto the sinkDataVerification