feat: Add back blocking send method based on non-blocking version #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirias
force-pushed
the
feature/blocking-send
branch
from
cf31700 to
a70f665
Compare
|
Updated the commit message to make it clear that this is a breaking change. |
cirias
changed the title
cirias
force-pushed
the
feature/blocking-send
branch
from
daf16db to
adbf125
Compare
cirias
force-pushed
the
feature/blocking-send
branch
from
adbf125 to
c586f15
Compare
cirias
changed the title
mattisonchao
approved these changes
May 15, 2024
|
HI, @cirias |
@mattisonchao I would love to. I'm busy with my job recently, but will work on an PR once I have some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all non blocking send methods to be suffixed with
_non_blocking. Per request from Revert "feat: Change send to not block on waiting receipt (#298)" #310.Fix missing image of pulsar in CI job.