client [NET-992]: pre-compiled JSON schema validator #1642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Compile JSON schema validator functions at build time instead of run time as described here https://ajv.js.org/standalone.html to avoid having to rely on
eval
during run time. Another added benefit is that we don't need to includeajv
in our webpack build, reducing the browser bundle size slightly.Changes
ajv
andajv-format
as dev dependencies.bin/generate-config-validator.js
that generates the pre-built JSON schema validator function.prebuild
phase, ensuring it gets called every time the client package is built.src/generated
for generated code that gets ignored by eslint.Checklist before requesting a review
TODO
comments left behind are meant to be left in.