Skip to content

Commit

Permalink
fix typo found by codespell
Browse files Browse the repository at this point in the history
  • Loading branch information
@matkoniecz
matkoniecz committed Nov 11, 2021
1 parent f05007f commit 9276a4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/src/main/java/de/westnordost/streetcomplete/quests/kerb_height/KerbUtil.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ private val allowedKeysOnKerbNodeRegexes = getLastCheckDateKeys(".*").map { it.t
* If any node **could** be a kerb, this would lead to an unacceptable performance hit when any
* node is updated due to an answered quest. See
* https://github.com/streetcomplete/StreetComplete/pull/3104#issuecomment-889833381 for more
* details ony why this function exists */
* details on why this function exists */
fun Node.couldBeAKerb(): Boolean = tags.keys.all { key ->
key in allowedKeysOnKerbNode || allowedKeysOnKerbNodeRegexes.any { regex -> regex.matches(key) }
}
Expand Down

3 comments on commit 9276a4c

@peternewman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I'd already pointed codespell at SC, but clearly not! You should setup our action when you've got it clean and a good config:
https://github.com/codespell-project/actions-codespell/

@matkoniecz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StreetComplete has surprisingly many false positives for codespell.

@peternewman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised by that, can you gather a config/exclude file and we can get some CI sorted, and look at why it's got so many false positives.

For comparison:
https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/workflows/codespell.yml
https://github.com/openstreetmap/iD/blob/develop/.github/workflows/codespell.yml

Please sign in to comment.