Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix command line exclusions #1119

Merged
merged 4 commits into from
Apr 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:

repo:
- php/php-src
- googleapis/google-cloud-cpp
- aws-amplify/docs
- Azure/azure-rest-api-specs
- alexiosc/megistos
Expand Down Expand Up @@ -55,4 +56,4 @@ jobs:
&& npm ci
&& npm run integration-tests -- ${{ matrix.repo }}

# cspell:ignore MartinThoma
# cspell:ignore MartinThoma googleapis
35 changes: 34 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,47 @@ on:
- master

jobs:
test:
test-old-node-versions:
runs-on: ${{ matrix.os }}

strategy:
matrix:
node-version:
# List of supported node versions (latest is tested in `test-os`)
- 12.x
- 14.x

os:
- ubuntu-latest

steps:
- uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/[email protected]
with:
node-version: ${{ matrix.node-version }}

- run: npm ci

- run: npm test

- name: verify trace command
run: node ./bin.js trace test

- name: verify the spell checker runs
run: node ./bin.js -c cspellrc.json

# Ensure the repository is clean after build & test
- run: git --no-pager diff --compact-summary --exit-code

test-os:
runs-on: ${{ matrix.os }}

strategy:
matrix:
node-version:
# Test the latest node version here, move older versions to `test-old-node-versions`
- 15.x

os:
Expand Down
12 changes: 12 additions & 0 deletions integration-tests/config/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,18 @@
],
"branch": "issue-1114",
"commit": "issue-1114"
},
{
"path": "googleapis/google-cloud-cpp",
"url": "https://github.com/googleapis/google-cloud-cpp.git",
"args": [
"-c",
"ci/cspell.json",
"**/*",
"-e",
"{*.BUILD,BUILD,CHANGELOG.md,*.sh,*.cfg,*.ps1,Dockerfile.*,*.Dockerfile,*.{yaml,xml,json,cmake}}"
],
"commit": "67f0ddcdb83bc47198fcdd6a504f18ca471cab8c"
}
]
}
328 changes: 328 additions & 0 deletions integration-tests/snapshots/googleapis/google-cloud-cpp/snapshot.txt

Large diffs are not rendered by default.

Loading