Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new CSpellSettingsDef.ts #2819

Merged
merged 11 commits into from
May 11, 2022
Merged

new CSpellSettingsDef.ts #2819

merged 11 commits into from
May 11, 2022

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented May 10, 2022

No description provided.

Copy link
Collaborator

@Jason3S Jason3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this.

packages/cspell-types/src/CSpellSettingsDef.ts Outdated Show resolved Hide resolved
packages/cspell-types/src/CSpellSettingsDef.ts Outdated Show resolved Hide resolved
packages/cspell-types/src/CSpellSettingsDef.ts Outdated Show resolved Hide resolved
packages/cspell-types/src/CSpellSettingsDef.ts Outdated Show resolved Hide resolved
packages/cspell-types/src/CSpellSettingsDef.ts Outdated Show resolved Hide resolved
packages/cspell-types/src/CSpellSettingsDef.ts Outdated Show resolved Hide resolved
packages/cspell-types/src/CSpellSettingsDef.ts Outdated Show resolved Hide resolved
@Jason3S
Copy link
Collaborator

Jason3S commented May 10, 2022

If you run npm i in the root, it will also build the schema files.

@Zamiell
Copy link
Contributor Author

Zamiell commented May 11, 2022

I committed the results from npm i just now.

Also, in the future, if it's an actual typo or a mistake in the commit, you don't have to "suggest" the change, you can just use GitHub to edit my PR directly, since you are a maintainer.
That avoids a useless ping-pong back and forth where it takes one extra step to get smaller changes in the PR.
You should typically only be "suggesting" changes if it is something you are unsure about, like if you are changing some code that might break something else in my PR.

@Jason3S Jason3S merged commit 6b23893 into streetsidesoftware:main May 11, 2022
@Zamiell Zamiell deleted the defs branch May 11, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants