Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FURL enhancements #1

Merged
merged 4 commits into from
Jul 21, 2012
Merged

FURL enhancements #1

merged 4 commits into from
Jul 21, 2012

Conversation

aguinet
Copy link
Contributor

@aguinet aguinet commented Jul 18, 2012

Hello,

Here are some furl enhancements. Basically, no memory is allocated for a temporary buffer and only positions and sizes of all different fields are saved. A test case has been added in order to check for regressions in future developments. Moreover, C99 is used.

Adrien Guinet added 4 commits July 18, 2012 11:17
* do not allocate a temporaray string, because all we find is indexes and no modification is made (maybe that wanted to be done in the future ?)
* remove structure with list of pointers
* in furl_features_t, put a list of (pos,size) tuple that identifies each field of the url
* adapt API according to these changes
* uses C99
Previous "domain" field is renamed as "host", that is :
blabla.mysubdomain.mysite.com == host
<----------------> <-------->
    subdomain        domain
stricaud added a commit that referenced this pull request Jul 21, 2012
FURL enhancements from Adrien Guinet
@stricaud stricaud merged commit 8703f6a into stricaud:master Jul 21, 2012
stricaud pushed a commit that referenced this pull request Jun 4, 2014
stuff valgrind complained about.

Rule #1: Valgrind is right. Rule #2: Valgrind is right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants