Skip to content

Commit

Permalink
[DOC] Improve the host field description to make the default value mo…
Browse files Browse the repository at this point in the history
…re clear (#10073)

Signed-off-by: Jakub Scholz <[email protected]>
  • Loading branch information
scholzj authored May 8, 2024
1 parent 67b6514 commit 93ed104
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ public void setResource(AclRuleResource resource) {
this.resource = resource;
}

@Description("The host from which the action described in the ACL rule is allowed or denied.")
@Description("The host from which the action described in the ACL rule is allowed or denied. " +
"If not set, it defaults to `*`, allowing or denying the action from any host.")
@JsonProperty(defaultValue = "*")
@JsonInclude(JsonInclude.Include.NON_DEFAULT)
public String getHost() {
Expand Down
2 changes: 1 addition & 1 deletion documentation/modules/appendix_crds.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -3141,7 +3141,7 @@ include::../api/io.strimzi.api.kafka.model.user.acl.AclRule.adoc[leveloffset=+1]
|Indicates the resource for which given ACL rule applies.
|host
|string
|The host from which the action described in the ACL rule is allowed or denied.
|The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host.
|operation
|string (one of [Read, Write, Delete, Alter, Describe, All, IdempotentWrite, ClusterAction, Create, AlterConfigs, DescribeConfigs])
|**The `operation` property has been deprecated, and should now be configured using `spec.authorization.acls[*].operations`.** Operation which will be allowed or denied. Supported operations are: Read, Write, Create, Delete, Alter, Describe, ClusterAction, AlterConfigs, DescribeConfigs, IdempotentWrite and All.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down Expand Up @@ -361,7 +361,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down Expand Up @@ -592,7 +592,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down
6 changes: 3 additions & 3 deletions packaging/install/cluster-operator/044-Crd-kafkauser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down Expand Up @@ -360,7 +360,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down Expand Up @@ -591,7 +591,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down
6 changes: 3 additions & 3 deletions packaging/install/user-operator/04-Crd-kafkauser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down Expand Up @@ -360,7 +360,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down Expand Up @@ -591,7 +591,7 @@ spec:
description: Indicates the resource for which given ACL rule applies.
host:
type: string
description: The host from which the action described in the ACL rule is allowed or denied.
description: "The host from which the action described in the ACL rule is allowed or denied. If not set, it defaults to `*`, allowing or denying the action from any host."
operation:
type: string
enum:
Expand Down

0 comments on commit 93ed104

Please sign in to comment.