Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systems tests should run against RBAC enabled Minikube #287

Closed
scholzj opened this issue Mar 6, 2018 · 0 comments
Closed

Systems tests should run against RBAC enabled Minikube #287

scholzj opened this issue Mar 6, 2018 · 0 comments

Comments

@scholzj
Copy link
Member

scholzj commented Mar 6, 2018 •
edited
Loading

Minikube has RBAC disabled by default. This leaves a huge area of things which can go wrong even when the system tests pass. One such example is #286. We should run the tests against Minikube with RBAC enabled (should be minikube start --extra-config=apiserver.Authorization.Mode=RBAC AFAIK).

Note: This should be done only after #286 which would break the tests immediately ;-)
scholzj added a commit that referenced this issue Apr 2, 2018
@scholzj
Enable RBAC in Minikube - Closes #287
5b0ea2f 
Add role through sudo

Remove sudo

Do not add binding

Is the cluster available later?

Further debugging

More debugging

More debugging

More debugging

More debugging

Increase timeout
@scholzj scholzj mentioned this issue Apr 2, 2018
Merged
@scholzj scholzj closed this as completed in 5e6efc1 Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scholzj