[ST] Fix RackAwarenessST, JmxST, and file-sink image build #10060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <[email protected]>
Frawless
approved these changes
May 3, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR fixes following issues:
RackAwarenessST- in assertions where we are checking that the hostname is in the particular line of text, we are assuming that there will be just the hostname we are specifying, however for example on AWS, there can be also additional suffix (like region)JmxST- when running with NP default to deny, we are not able to connect to the API and get the JMX metrics, this PR adds creation of NP for Connect, so we are able to successfully collect the particular beans.jar), the build simply fails, as the jar can be named differently (with different suffix)Checklist