Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RackAwareDistributionGoal to CC goal config by default #10333

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

kyguy
Copy link
Member

@kyguy kyguy commented Jul 11, 2024

Type of change

  • Enhancement / new feature

Description

Resolves #10297

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@kyguy kyguy added this to the 0.43.0 milestone Jul 11, 2024
@kyguy kyguy force-pushed the add-RackAwareDistributionGoal branch from d429038 to a7f5ff8 Compare July 12, 2024 15:04
@kyguy kyguy marked this pull request as ready for review July 12, 2024 16:03
@kyguy kyguy requested review from scholzj, ppatierno and fvaleri July 12, 2024 16:03
@scholzj
Copy link
Member

scholzj commented Jul 12, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member

scholzj commented Jul 12, 2024

Thanks for looking into this @kyguy

Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kyguy.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ppatierno ppatierno merged commit 1ae40e2 into strimzi:main Jul 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for RackAwareDistributionGoal in Cruise Control with Strimzi
6 participants