Fix topicId status update #10491
Merged
Fix topicId status update #10491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strimzi/maintainers can we run STs on this? Thanks. |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tombentley
reviewed
Aug 27, 2024
topic-operator/src/main/java/io/strimzi/operator/topic/BatchingTopicController.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/BatchingTopicController.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/BatchingTopicController.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/BatchingTopicController.java
Outdated
Show resolved
Hide resolved
|
Failed test is unrelated: [ERROR] io.strimzi.operator.cluster.operator.assembly.KafkaConnectorIT.testConnectorIsAutoRestarted(VertxTestContext)
[ERROR] Run 1: KafkaConnectorIT.testConnectorIsAutoRestarted(VertxTestContext) java.lang.AssertionError:
Expected: is "RESTARTING"
but: was "UNASSIGNED"
[ERROR] Run 2: KafkaConnectorIT.testConnectorIsAutoRestarted(VertxTestContext) java.lang.AssertionError:
Expected: is "RESTARTING"
but: was "UNASSIGNED"
[ERROR] Run 3: KafkaConnectorIT.testConnectorIsAutoRestarted(VertxTestContext) java.lang.AssertionError:
Expected: is "RESTARTING"
but: was "UNASSIGNED" |
|
/packit test --labels regression |
|
@tombentley system tests looks mostly good with the exception of OpenTelemetryST, which is a known issue unrelated to this PR. Let me know if you are good with latest changes. Thanks. |
|
/packit test --labels regression |
The KafkaTopic.status.topicId keeps the old value when the topic is recreated in Kafka while the reconciliation is paused/disabled, or the operator is not running. This change adds the topicId when the KafkaTopic is managed and topicId is not set, and removes the topicId when KafkaTopic is paused or unmanaged. Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
|
/packit test --labels regression |
|
Thanks, I think we are good to go. |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failed tests are unrelated and succeeded on packit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Description
The KafkaTopic.status.topicId keeps the old value when the topic is recreated in Kafka while the reconciliation is paused/disabled, or the operator is not running.
This change adds the topicId when the KafkaTopic is managed and topicId is not set, and removes the topicId when KafkaTopic is paused or unmanaged.
Should close #10467.
Checklist