Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(oauth): sasl extensions for custom oauthbearer implementations #10523

Merged
merged 2 commits into from
Sep 2, 2024
Merged

docs(oauth): sasl extensions for custom oauthbearer implementations #10523

merged 2 commits into from
Sep 2, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Aug 30, 2024 •
edited
Loading

Documentation

Adds a description of adding SASL extensions for custom oauthbearer mechanisms to the Configuring OAuth 2.0 on client applications section in the Deploying guide

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.44.0 milestone Aug 30, 2024
@PaulRMellor PaulRMellor requested a review from mstruk August 30, 2024 13:30
@PaulRMellor PaulRMellor self-assigned this Aug 30, 2024
scholzj
scholzj approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should be reviewed by @mstruk as the SME.

mstruk
mstruk approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@mstruk mstruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, but maybe it would be better to move it to the end of this doc. Just a suggestion.

@PaulRMellor
Copy link
Contributor Author

The content looks good, but maybe it would be better to move it to the end of this doc. Just a suggestion.

Thanks @mstruk. Moved

@PaulRMellor PaulRMellor merged commit e815d6b into strimzi:main Sep 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstruk mstruk mstruk approved these changes

@scholzj scholzj scholzj approved these changes

Assignees

@PaulRMellor PaulRMellor

Labels
documentation
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulRMellor @mstruk @scholzj