Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(quota plugins): note on quotas for internal users #10803

Merged
merged 6 commits into from
Nov 9, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Nov 5, 2024

Documentation

Adds a description of the impact on internal users when applying quotas through the Kafka quotas plugin.
Describes how Topic Operator and Cruise Control operations can be affected and how to avoid any impact.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor requested review from kyguy, fvaleri and a team November 5, 2024 10:54
@PaulRMellor PaulRMellor self-assigned this Nov 5, 2024
Copy link

@pwright pwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I made one dodgy suggestion, and would ask the question:
how do you monitor the situation to avoid trottling?

@PaulRMellor PaulRMellor added this to the 0.45.0 milestone Nov 5, 2024
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@PaulRMellor
Copy link
Contributor Author

Thanks for the reviews @kyguy and @scholzj
The procedure just introduces the two plugins now and keeps this info with the Kafka plugin

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one nit, but this looks reasonable to me.

@PaulRMellor
Copy link
Contributor Author

Thanks @kyguy -- I've expanded on the potential impact to the TO operations as suggested.

@scholzj scholzj merged commit 4e09701 into strimzi:main Nov 9, 2024
13 checks passed
@PaulRMellor PaulRMellor linked an issue Nov 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Kafka user quotas are applied also to internal users
7 participants