Improve min.insync.replicas parsing in warnTooLargeMinIsr

[fvaleri]

Type of change

• Enhancement / new feature

Description

When reconciling a replicas change, we check the target number of replicas against the configured minISR. In that case, a ClassCastException is raised if the user sets min.insync.replicas: "1" (quoted value). This patch aligns this configuration parsing to the rest of the code, where this is tolerated.

Checklist

• Make sure all tests pass
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

[fvaleri]

The failed test TopicControllerIT#shouldUpdateTopicInKafkaWhenConfigRemovedInKube is not related to the change and it seems to work fine locally. Will continue the investigation.

[scholzj]

I guess there should be some test for it if we want to support both String and Integer formats?

[see-quick]

LGTM

[fvaleri]

@ppatierno @see-quick is this ready to merged?

[see-quick]

I guess there should be some test for it if we want to support both String and Integer formats?

@ppatierno @see-quick is this ready to merged?

I assume this test case replicasChangeShouldBeReconciled covers the String format. I don't see any Integer format, but I would expect many tests to cover Integer format (as it was the default). Am I right?

[fvaleri]

I guess there should be some test for it if we want to support both String and Integer formats?

@ppatierno @see-quick is this ready to merged?

I assume this test case replicasChangeShouldBeReconciled covers the String format. I don't see any Integer format, but I would expect many tests to cover Integer format (as it was the default). Am I right?

Correct. The issue was triggered specifically by a RF change, that's why I added there.