Refactor use of Informers in UO and SPS controller #10885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Nov 28, 2024
...trimzi/operator/cluster/operator/resource/kubernetes/AbstractNamespacedResourceOperator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
OwenCorrigan76
pushed a commit
to OwenCorrigan76/strimzi-kafka-operator
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Jakub Scholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR refactors how we use Informers in our current code base (User Operator and StrimziPodSetController). It creates a new wrapper/encapsulation of the informer and lister to make it easier to share them through the code and query the cache. This should simplify the existing code and make it easier to introduce informers in other parts of the code base.
Checklist