Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Add STs for Connector offset management feature #10904

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Dec 3, 2024

Type of change

  • New tests

Description

This PR adds test and test check for the new Connector offset management feature added in #10563 .
For the KafkaConnect and KafkaConnector it adds whole ST into the ConnectST, where it goes through all the operations that we can do -> list, alter, reset.
In order to check that everything works also for KafkaMirrorMaker2ST, I added one check to the MirrorMaker2ST, just for listing the offsets (and verifying that it will go through the API correctly).

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@im-konge im-konge marked this pull request as ready for review December 3, 2024 19:56
@im-konge im-konge requested review from katheris and a team December 3, 2024 19:56
@im-konge im-konge self-assigned this Dec 3, 2024
@im-konge im-konge added this to the 0.45.0 milestone Dec 3, 2024
@im-konge
Copy link
Member Author

im-konge commented Dec 3, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Lukas! just one question.

Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@im-konge im-konge merged commit 2b810bb into strimzi:main Dec 4, 2024
21 checks passed
@im-konge im-konge deleted the connector-offsets branch December 4, 2024 19:00
OwenCorrigan76 pushed a commit to OwenCorrigan76/strimzi-kafka-operator that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants