Fix JMV options for Kafka Mirror Maker #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Connect and COnnect S2I - Closes #1569
ppatierno
approved these changes
Apr 24, 2019
scholzj
added a commit
that referenced
this pull request
Apr 26, 2019
Fix JMV options for Kafka Mirror Maker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The Mirror Maker deployment seems to be missing loading of JVM options from the custom resource. This was raised in #1569.
This PR adds the JVM options loading from the CR and corresponding tests. It also adds the tests for the JVM options and Resources to Connect and Connect S2I.
Checklist