Move the maintenance window from rolling updates to CA #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strimzi-ci run tests |
|
Test Failures
|
|
@strimzi-ci run tests |
|
Test Failures
|
|
@strimzi-ci run tests |
|
Test Failures
|
|
@strimzi-ci run tests testcase=KafkaST#testKafkaJBODDeleteClaimsTrueFalse, HelmChartST#HelmChartST |
scholzj
added a commit
that referenced
this pull request
Jun 24, 2019
* Move the maintenance window from rolling updates to CA * fix tests and fix findbugs * Add tests for maintenance window in CA
|
Merged and picked for 0.12.x release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The MaintenanceWindow currently doesn't work because change of certificates changes the
strimzi.io/clients-ca-cert-generationandstrimzi.io/cluster-ca-cert-generationannotations in the Pod template in STS and these trigger rolling updateThe whole maintenance window seems to be rather unfortunately addressed in the rolling update and not in the CA it self. That can leave to the certificates being updated in the secrets possibly a long time before the rolling update activates them. This does not seem to be correct. The maintenance time window check should be moved to the Ca class so that the certificates are regenerated only when the maintenance window starts.
This should be picked for the 0.12.x branch for possible patch release.
Checklist