Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added not FQDN in the SAN list #871

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Added not FQDN in the SAN list #871

merged 1 commit into from
Sep 19, 2018

Conversation

ppatierno
Copy link
Member

Type of change

  • Bugfix

Description

This PR fixes #870 adding a not FQDN to the SAN list for broker certificates.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@ppatierno ppatierno requested a review from scholzj September 18, 2018 13:11
@ppatierno ppatierno merged commit a97a7ea into master Sep 19, 2018
@scholzj scholzj added this to the 0.8.0 milestone Sep 19, 2018
@ppatierno ppatierno deleted the san-not-fqdn branch September 20, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Kafka brokers certificates doesn't have the alternative name $serviceName.$namespace
2 participants
@ppatierno @scholzj