-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic replication factor change #9483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvaleri
force-pushed
the
topic-rf-change
branch
2 times, most recently
from
December 21, 2023 18:08
ecbc282
to
916f3c3
Compare
fvaleri
force-pushed
the
topic-rf-change
branch
from
December 23, 2023 07:29
916f3c3
to
0817376
Compare
fvaleri
changed the title
Add topic replication factor change feature
Add topic replication factor change
Dec 23, 2023
fvaleri
force-pushed
the
topic-rf-change
branch
2 times, most recently
from
December 29, 2023 08:44
1bff12a
to
5f6b083
Compare
see-quick
reviewed
Dec 30, 2023
...on/src/main/java/io/strimzi/operator/common/model/cruisecontrol/CruiseControlParameters.java
Outdated
Show resolved
Hide resolved
fvaleri
force-pushed
the
topic-rf-change
branch
7 times, most recently
from
January 15, 2024 18:14
d5f205b
to
c0c23ae
Compare
fvaleri
force-pushed
the
topic-rf-change
branch
5 times, most recently
from
January 22, 2024 15:17
5bd15c0
to
4bcccd1
Compare
scholzj
requested changes
Mar 9, 2024
This change implements the proposal about topic replication factor change. Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
fvaleri
force-pushed
the
topic-rf-change
branch
from
March 11, 2024 15:27
e7ba100
to
23a28d0
Compare
scholzj
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the proposal about topic replication factor change.
https://github.com/strimzi/proposals/blob/main/066-topic-replication-factor-change.md
Documentation will be added in a separate PR.
To avoid making the review of new components harder, there is a small amount of duplication related to Cruise Control client. This will be addressed in a follow up PR, where I plan to move the shared part between Rebalance and Topic operator in the operator-common module, and to switch from Vertx HTTP client to Java HTTP client.
Unit tests are included, but I also performed a number of manual tests on Minikube and OpenShift that could help in testing the feature, and creating system tests:
$CLUSTER_NAME-cruise-control-api
should roll CC$CLUSTER_NAME-entity-topic-operator-cc-api
should roll both EO and CC.status.replicasChange.message
and reverting the change should clear that status.spec.config."min.insync.replicas" < .spec.replicas
should work logging a warning