Add warnings when unused fields are set when Node Pools or Kraft are used #9553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jakub Scholz <[email protected]>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
approved these changes
Jan 14, 2024
scholzj
deleted the
add-warnings-when-unsused-fields-are-used-with-node-pools-or-kraft
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
With
UseKRaftnow being enabled by default, users are not required to set the following sections in the Kafka CR:.spec.kafka.replicas.spec.kafka.storage.spec.zookeeperWhen Node Pools are used, the storage and replicas configuration in the KAfka CR are ignored. When KRaft is used in addition to Node Pools, the ZooKeeper section is not used either. This PR adds warning conditions when these ignored sections are set in the custom resource to get the users to remove them.
I originally considered setting those in the
KafkaSpecCheckerclass. But that adds warning conditions based on the model classes and not based on the custom resources. It would require passing additional parameters through several classes. That seemed like a lot of effort for something that will eventually go away once ZooKeeper support is dropped completely by Kafka and Strimzi. So at the end, I added them as static methods that are called in the place where the validation of these fields happens in theKafkaAsssemblyOperatorChecklist