-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kraft): adds a procedure for zookeeper to kraft migration #9633
Conversation
Signed-off-by: prmellor <[email protected]>
documentation/assemblies/upgrading/assembly-upgrade-zookeeper.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/managing/con-custom-resources-status.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
documentation/assemblies/upgrading/assembly-upgrade-zookeeper.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
Signed-off-by: prmellor <[email protected]>
Signed-off-by: PaulRMellor <[email protected]>
documentation/assemblies/upgrading/assembly-upgrade-zookeeper.adoc
Outdated
Show resolved
Hide resolved
@PaulRMellor I added the "do-not-merge" label because this one should anyway wait for the implementation in #9480 being merged as well. |
Signed-off-by: prmellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But it shoud be approved by Paolo as the migration SME.
documentation/assemblies/upgrading/assembly-upgrade-zookeeper.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first iteration adding a few comments, I would also do the second one to check all procedures you have add here.
Signed-off-by: prmellor <[email protected]>
Signed-off-by: prmellor <[email protected]>
Signed-off-by: prmellor <[email protected]>
Signed-off-by: prmellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
As already said we'll not merge this until the corresponding implementation PR #9480 is merged as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Left some comments.
@PaulRMellor while having an offline chat with @fvaleri it could be worth mentioning that if your initial configuration has the inter broker protocol and/or log message format set, you should remove them at the end of the migration. The brokers and controllers will be rolled one more time to update them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments from me 👍 Looks good
Signed-off-by: prmellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaulRMellor We should take all the updates not related to migration out of this PR but having a new one for them. I see you updated annotation values in all other places, but I would move them for a new PR. Let's take this PR for migration only.
Signed-off-by: prmellor <[email protected]>
8c7f5e9
to
2d80e20
Compare
Signed-off-by: prmellor <[email protected]>
Signed-off-by: prmellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Back to green!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
@PaulRMellor I don't see addressed the above comment here. |
Signed-off-by: prmellor <[email protected]>
Signed-off-by: prmellor <[email protected]>
Documentation
Adds a new procedure that describes how to migrate from ZooKeeper-based to KRaft-based Kafka cluster.
Also includes steps to roll back, if required.
Checklist
Please go through this checklist and make sure all applicable tasks have been done