-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] fixing unnecessary error logs when cleaning resources #9667
Conversation
Signed-off-by: hzrncik <[email protected]>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
the fail of the test in Azure has nothing to do with changes. The test is actually flaky and fails on both this and main branch as well (approx 40% of time) will be fixed in separe from this PR. |
Well but for sure you should resolve problem with spotbugs i.e., [INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[ERROR] Medium: Do not catch NullPointerException like in io.strimzi.systemtest.resources.ResourceManager.deleteResource(HasMetadata[]) [io.strimzi.systemtest.resources.ResourceManager] At ResourceManager.java:[line 349] DCN_NULLPOINTER_EXCEPTION
[INFO] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a cleanup stuff, but I saw similar NPE also in other "wait for methods", which are a bit misleading in the log. Do you want to look at those in different PR?
Anyway, this LGTM, just fix the spotbugs check
Signed-off-by: hzrncik <[email protected]>
|
Type of change
Description
all changes made in order to avoid error logs (mostly null pointers) when removing Kafka resources and namespaces.
additionally removal of several explicit kafka deletions in the end of the test as they are not necessary there (and are commonly no longer used as we have cleaning set up).