[ST] Remove un-necessary check inside testKafkaConnectAndConnectorStatus #9673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
approved these changes
Feb 10, 2024
henryZrncik
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR removes unnecessary checks to the
testKafkaConnectAndConnectorStatustest case, causing many failures. We could resolve such a problem by changing a FileSource connector file config (i.e.,/opt/kafka/LICENSE) and changing it to some/tmp/test-file.txtand then update it to always have it involved. Currently in the second stage of the test when we do not update the file/opt/kafka/LICENSEthe KafkaConnect API will not append a topic inside.statusof the KafkaConnnector CR because it does not have any records or it is not active (no new data comes because the file is still the same). But such a solution seems to be an overkill and we would rather remove these checks.Checklist