-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] Enhance DrainCleanerST #9829
Conversation
Signed-off-by: Lukas Kral <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! thanks.
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --testcase=DrainCleanerST |
|
✔️ Test Summary ✔️TEST_PROFILE: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
@strimzi-ci run tests --cluster-type=minikube --cluster-version=stable --install-type=bundle --profile=all --testcase=DrainCleanerST --env=STRIMZI_USE_KRAFT_IN_TESTS=true |
|
✔️ Test Summary ✔️TEST_PROFILE: all |
Type of change
Description
This PR enhances the
DrainCleanerST
with following:ACCEPTANCE
toREGRESSION
kubernetes
/openshift
) based on cluster typeAdditionally, it adds new method
isOpenShiftLikeCluster()
toKubeClusterResource
, which is useful in case that we want to determine, if the cluster is "OpenShift-like" -> in our case OpenShift or MicroShift.Checklist