Add a single node KRaft example for use in quickstarts #9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
im-konge
approved these changes
Mar 14, 2024
see-quick
approved these changes
Mar 14, 2024
fvaleri
approved these changes
Mar 14, 2024
| For instance, JBOD storage is not supported (you can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume). | ||
| To use KRaft, ensure that the and `UseKRaft` feature gate is not disabled. | ||
| Please note that ZooKeeper-less Apache Kafka is still under development and has some limitations. | ||
| For instance, scaling of controller node or JBOD storage (you can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume) are not supported. |
There was a problem hiding this comment.
Suggested change
| For instance, scaling of controller node or JBOD storage (you can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume) are not supported. | |
| For instance, scaling of controller node or JBOD storage are not supported. | |
| You can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume. |
There was a problem hiding this comment.
The JBOd note belongs specifically to the JBOD storage part, so I think it is better to have it directly there.
There was a problem hiding this comment.
Ok, but it's kind of weird to read. What about "If you still want to use JBOD, you can specify..."
Signed-off-by: Jakub Scholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds a new KRaft example for a single node KRaft cluster. This would be useful in the quickstarts on our website to replace the ZooKeeper which has DNS issues for some users.
It also fixes the 20Gi storage in some of the other Kraft examples - that seems a copy-paste error - and brings it in sync with our other examples where we use 100Gi.
It also updates the README file to correspond to the latest changes.
Checklist