-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] (Kraft)KafkaUpgradeDowngrade decrease tests durations #9852
Merged
see-quick
merged 1 commit into
strimzi:main
from
henryZrncik:upgrade-downgrade-timououts
Mar 20, 2024
Merged
[ST] (Kraft)KafkaUpgradeDowngrade decrease tests durations #9852
see-quick
merged 1 commit into
strimzi:main
from
henryZrncik:upgrade-downgrade-timououts
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hzrncik <[email protected]>
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
approved these changes
Mar 19, 2024
see-quick
approved these changes
Mar 20, 2024
steffen-karlsson
pushed a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
) Signed-off-by: hzrncik <[email protected]> Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
added a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
…trimzi#9852)" This reverts commit f70d6b3.
steffen-karlsson
pushed a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
) Signed-off-by: hzrncik <[email protected]> Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
added a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
…trimzi#9852)" This reverts commit f70d6b3. Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
pushed a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
) Signed-off-by: hzrncik <[email protected]> Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
pushed a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
) Signed-off-by: hzrncik <[email protected]> Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
added a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
…trimzi#9852)" This reverts commit f70d6b3. Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
pushed a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Mar 21, 2024
) Signed-off-by: hzrncik <[email protected]> Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
pushed a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Apr 2, 2024
) Signed-off-by: hzrncik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Decreasing the time to send/receive messages for continuous producer and consumer per each test in
KRaftKafkaUpgradeDowngradeST
andKafkaUpgradeDowngradeST
to half, as wait that long is unnecessary.8 Tests in
KRaftKafkaUpgradeDowngradeST
andKafkaUpgradeDowngradeST
are always waiting for consumer and producer to finish successfully before the end of the tests if we are sending 1000 messages = ~16 minutes. Only ~7 minutes of this seems to be actually necessary, Causing almost 9 minutes of extra waiting per test.notice time of waiting in log under of one of the tests.
The wait is now only ~500 seconds which gives 20% extra in addition to most of observed execution times.
execution of these tests under
upgrade
profile takes ~3hours, this would decrease it by almost half (8 * 9minutes).