Refactor InitWriterConfig

[Staniel]

Type of change

Select the type of your PR

• Refactoring

Description

Refactor the InitWriterConfig in the kafka-init module to use the shared classes, fix #9881

Checklist

Please go through this checklist and make sure all applicable tasks have been done

• Write tests
• Make sure all tests pass
• Update documentation
• Check RBAC rights for Kubernetes / OpenShift roles
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
• Reference relevant issue(s) and close them after merging
• Update CHANGELOG.md
• Supply screenshots for visual changes, such as Grafana dashboards

[scholzj]

/azp run regression

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[scholzj]

I think the system tests failed because the config libraries cannot handle true / false unless they are in lower case and the Cluster Operator sets it in upper case. I think you have to update the method for parsing the boolean in ConfigParameterParser to use equalsIgnoreCase instead:

    /**
     * A Java Boolean
     */
    ConfigParameterParser<Boolean> BOOLEAN = configValue -> {
        if (configValue.equalsIgnoreCase("true") || configValue.equalsIgnoreCase("false")) {
            return Boolean.parseBoolean(configValue);
        } else {
            throw new InvalidConfigurationException("Failed to parse. Value " + configValue + " is not valid");
        }
    };

[Staniel]

I think the system tests failed because the config libraries cannot handle true / false unless they are in lower case and the Cluster Operator sets it in upper case. I think you have to update the method for parsing the boolean in ConfigParameterParser to use equalsIgnoreCase instead:

    /**
     * A Java Boolean
     */
    ConfigParameterParser<Boolean> BOOLEAN = configValue -> {
        if (configValue.equalsIgnoreCase("true") || configValue.equalsIgnoreCase("false")) {
            return Boolean.parseBoolean(configValue);
        } else {
            throw new InvalidConfigurationException("Failed to parse. Value " + configValue + " is not valid");
        }
    };

Done

[scholzj]

/azp run regression

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[scholzj]

Thanks. LGTM.

[ppatierno]

LGTM. Thanks for the PR!