-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] Move AZP profiles from STs' pom.xml and remove profiles related to Jenkins #9942
Conversation
Signed-off-by: Lukas Kral <[email protected]>
/azp list |
/azp run acceptance |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is that used on Azure only?
Those profiles with prefix The |
Well, I guess it has nothing to do with scripts, so that likely isn't the right place. And if it is no Azure only, what about some more neutral place? E.g. as a resource in system tests? Or next to the pom.xml in system tests? Or something like that? |
I thought that having it in the |
Well, the |
The So the But yeah, you are right that it's not related to the scripts, so moving it from the scripts folder to |
I changed the PR name and description - that should make the things clearer. |
Signed-off-by: Lukas Kral <[email protected]>
/azp run bridge |
Azure Pipelines successfully started running 1 pipeline(s). |
Type of change
Description
This PR creates a new settings XML file for the STs profiles for the AZP located in the
.azure/systemtests
folder and remove all the AZP profiles from STs'pom.xml
file.The movement of these profiles from the
pom.xml
file was discussed multiple times and as mentioned -> we should not have various profiles of the STs for each CI in thepom.xml
, but we should follow the path of having thesettings.xml
containing needed profiles in each CI/CD.This PR also removes few of the profiles (
bridge
,olm_acceptance_upgrade
) that are used only on the Jenkins (and will be added into the separatesettings.xml
file directly on the Jenkins instance).The properties from
none
profile are set by default, so I removed that profile as well.Checklist