docs(diagrams): updates digrams to be more kraft friendly #9962
There are no files selected for viewing
|
There was a problem hiding this comment. The pod numbers here are confusing. Maybe we can remove them for both brokers and controllers and just have multiple squares with (The source of confusion is that you cannot have broker There was a problem hiding this comment. I don't think it's confusing. I wouldn't assume to think we're talking IDs here. I could make this obvious in the surrounding text if we really need to. If we change it, we lose consistency with the zookeeper diagram. What are your thoughts @scholzj? There was a problem hiding this comment. Well, as I said, I would remove the numbers from the picture. I think it can be confusing because the IDs play a key part and the way they work in KRaft with the same series used for everything is already confusing enough with KRaft based on some Slack questions. There was a problem hiding this comment. Okay. We don't want to cause any confusion. I'll get that updated. Any objections to removing the numbers from the zookeeper diagram for consistency sake? There was a problem hiding this comment. I would agree with Jakub and I am fine removing the numbers from ZooKeeper diagram as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a nit and I'm not sure it is worth changing the image. But all the other OAuth images seem to use
Kafka broker. Only this one seems to useKafka node. Might make sense to useKafka brokerhere as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't spot that. We'll change that back.