fix(helm): add conditional namespace on watchAnyNamespace true

[FlxPeters]

When the feature flag is enabled, the ClusterRoleBinding has a namespace which is not valid. In order to fix this a condition for the namespace is added to all relevant templates.

Type of change

Select the type of your PR

• Bugfix

Description

Please describe your pull request

Checklist

Please go through this checklist and make sure all applicable tasks have been done

• Write tests
• Make sure all tests pass
• Update documentation
• Check RBAC rights for Kubernetes / OpenShift roles
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
• Reference relevant issue(s) and close them after merging
• Update CHANGELOG.md
• Supply screenshots for visual changes, such as Grafana dashboards

[scholzj]

Thanks for the PR. I guess the debug.yaml should not be there? Also, you should change only the packaging folder. The /helm-charts folder is updated only as part of the release.

[FlxPeters]

Thanks for the PR. I guess the debug.yaml should not be there? Also, you should change only the packaging folder. The /helm-charts folder is updated only as part of the release.

Yep, just missed that one when commiting. Now all should be fine.

[scholzj]

Thanks for the PR. I guess the debug.yaml should not be there? Also, you should change only the packaging folder. The /helm-charts folder is updated only as part of the release.

Yep, just missed that one when commiting. Now all should be fine.

Sorry if I confused you ... but it looks like you did it the other way around -> /packaging/hlem-charts is where you should do the change. But /helm-charts has to remain unchanged.

[FlxPeters]

I was also confused by my own commit. I think it should be fine now?

[scholzj]

I was also confused by my own commit. I think it should be fine now?

No, you have the changes in the /helm-charts directory. They have to be packaging/helm-charts only.

[FlxPeters]

Oh, I feel some kind of dump right now... sorry for the chaos.
Now it should be finally fixed. My bad.

[scholzj]

That looks good now. Thanks.

[scholzj]

/azp run helm-acceptance

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ppatierno]

LGTM. Thanks for the PR!