Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use goveralls parallel build #229

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

harold-stripe
Copy link
Contributor

Description

Second attempt (#228) to try and fix the build
Following the parallel builds pattern by setting the COVERALLS_PARALLEL env and running goveralls -parallel-finish=true

Test

Looks like it works in https://github.com/stripe/smokescreen/actions/runs/10911519945

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10911572468

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.154%

Totals Coverage Status
Change from base Build 10909880132: 0.0%
Covered Lines: 1323
Relevant Lines: 2489

💛 - Coveralls

Copy link
Contributor

@cds2-stripe cds2-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@harold-stripe harold-stripe merged commit 735a6e8 into master Sep 17, 2024
9 checks passed
@harold-stripe harold-stripe deleted the harold/goveralls-build branch September 17, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants