Fix CRL for client certificates #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
CRL feature does not seem to work. There are two main issues with it:
Configstructure, but are not used anywhere. I've implementedVerifyPeerCertificatefunction in config.TlsConfigVerifyPeerCertificate, CRLs do not work since CRL loading occurs earlier, than CA loading. Smokescreen cannot find CA for CRL and fails. That's why I rearranged them.I wrote an integration test with its own CA generation procedure - I did not want to figure how to use your test PKI in testdata, so I generate PKI on the fly and clean it up afterwards.
This may look terrible, as it is just a draft. I'll clean it up, fix deprecation issues and resolve any of your comments if you are willing to merge it.