-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StripeSourceTypeModel is not public #616
Comments
@Huulivoide can you show a screenshot of the warning so we can figure out what to do about it? |
+1 to this issue. Is there a workaround for this @Huulivoide ? |
@Huulivoide @osrl can you help me understand what information you need to access on |
I needed to display some information about customers' sources:
I get the same warning like @Huulivoide |
@mshafrir-stripe Like osrl, I am not trying to access StripeSourceTypeModel directly at all. Instead, like osrl, I cast it to SourceCardData, to access the some of the cad details (brand, last 4 digits). Still the problem is that you have a public API method, that returns a instance of package private class. |
Maybe something like |
**Summary** - Make `StripeSourceTypeModel` public - Clean up the internal structure of `StripeSourceTypeModel` **Motivation** `Source#getSourceTypeModel()` is a public method, but it returns a type (`StripeSourceTypeModel`) that is package-private, causing warnings in the IDE. This is a safe change, because the methods in `StripeSourceTypeModel` that should not be accessed publicly are still package-private. In addition, `StripeSourceTypeModel` extends `StripeJsonModel`, which itself is public. Fixes #616
**Summary** - Make `StripeSourceTypeModel` public - Clean up the internal structure of `StripeSourceTypeModel` **Motivation** `Source#getSourceTypeModel()` is a public method, but it returns a type (`StripeSourceTypeModel`) that is package-private, causing warnings in the IDE. This is a safe change, because the methods in `StripeSourceTypeModel` that should not be accessed publicly are still package-private. In addition, `StripeSourceTypeModel` extends `StripeJsonModel`, which itself is public. Fixes #616
**Summary** - Make `StripeSourceTypeModel` public - Clean up the internal structure of `StripeSourceTypeModel` **Motivation** `Source#getSourceTypeModel()` is a public method, but it returns a type (`StripeSourceTypeModel`) that is package-private, causing warnings in the IDE. This is a safe change, because the methods in `StripeSourceTypeModel` that should not be accessed publicly are still package-private. In addition, `StripeSourceTypeModel` extends `StripeJsonModel`, which itself is public. Fixes #616
**Summary** - Make `StripeSourceTypeModel` public - Clean up the internal structure of `StripeSourceTypeModel` **Motivation** `Source#getSourceTypeModel()` is a public method, but it returns a type (`StripeSourceTypeModel`) that is package-private, causing warnings in the IDE. This is a safe change, because the methods in `StripeSourceTypeModel` that should not be accessed publicly are still package-private. In addition, `StripeSourceTypeModel` extends `StripeJsonModel`, which itself is public. Fixes #616
This is now available in |
Source.getSourceTypeModel() return the source model as type StripeSourceTypeModel, which is not public. Sure to use it one must cast it to one of public classes that actually implement it, but still Android studio will issue a warning about it.
The text was updated successfully, but these errors were encountered: