Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppress2faModal flag to LinkConfiguration #10054

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Jan 31, 2025

Summary

This is a backend flag that can disable launching the link 2fa when paymentsheet is opened

Motivation

JIRA

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

@toluo-stripe toluo-stripe marked this pull request as ready for review January 31, 2025 22:00
@toluo-stripe toluo-stripe requested review from a team as code owners January 31, 2025 22:00
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed         
          ├───────────┬───────────┬────────┼──────────┬──────────┬────────
 APK      │ old       │ new       │ diff   │ old      │ new      │ diff   
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
      dex │     4 MiB │     4 MiB │ +507 B │  8.7 MiB │  8.7 MiB │ +388 B 
     arsc │   2.3 MiB │   2.3 MiB │    0 B │  2.3 MiB │  2.3 MiB │    0 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │ 25.7 KiB │ 25.7 KiB │    0 B 
      res │ 910.3 KiB │ 910.3 KiB │    0 B │  1.4 MiB │  1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │    6 MiB │    6 MiB │    0 B 
    asset │   1.6 MiB │   1.6 MiB │    0 B │  1.6 MiB │  1.6 MiB │    0 B 
    other │   1.4 MiB │   1.4 MiB │   +8 B │  1.6 MiB │  1.6 MiB │    0 B 
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
    total │  12.7 MiB │  12.7 MiB │ +515 B │ 21.7 MiB │ 21.7 MiB │ +388 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 41101 │ 41103 │ +2 (+7 -5) 
   types │ 14216 │ 14216 │  0 (+0 -0) 
 classes │ 11873 │ 11873 │  0 (+0 -0) 
 methods │ 60380 │ 60380 │  0 (+4 -4) 
  fields │ 40529 │ 40532 │ +3 (+8 -5) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6245 │ 6245 │  0
APK
    compressed     │    uncompressed    │                        
──────────┬────────┼───────────┬────────┤                        
 size     │ diff   │ size      │ diff   │ path                   
──────────┼────────┼───────────┼────────┼────────────────────────
    4 MiB │ +507 B │   8.7 MiB │ +388 B │ ∆ classes.dex          
 53.6 KiB │   +6 B │ 118.8 KiB │    0 B │ ∆ META-INF/CERT.SF     
 50.3 KiB │   +2 B │ 118.8 KiB │    0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼────────┼───────────┼────────┼────────────────────────
  4.1 MiB │ +515 B │   8.9 MiB │ +388 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   41101 │ 41103 │ +2 (+7 -5) 
  
  + , suppress2faModal=
  + LLLLLZLZZLL
  + LLLLLZZLZZLL
  + VLLLLLZLLZZLL
  + VLZLLZLZZ
  + link_mobile_suppress_2fa_modal
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"d633fa0","r8-mode":"full","version":"8.7.14"}
  
  - LLLLLZLZLL
  - LLLLLZZLZLL
  - VLLLLLZLLZLL
  - VLZLLZLZ
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"b79a898","r8-mode":"full","version":"8.7.14"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   60380 │ 60380 │ 0 (+4 -4) 
  
  + Q6.s0 <init>(List, boolean, K0, Map, boolean, J0, boolean, boolean)
  + e8.v e(a, f, t0, String, boolean, Map, boolean, boolean, C, c) → Object
  + e8.v h(a, f, t0, String, boolean, boolean, Map, boolean, boolean, C, c) → Object
  + q6.s <init>(l3, String, String, r, a, boolean, Map, q, boolean, boolean, C, String)
  
  - Q6.s0 <init>(List, boolean, K0, Map, boolean, J0, boolean)
  - e8.v e(a, f, t0, String, boolean, Map, boolean, C, c) → Object
  - e8.v h(a, f, t0, String, boolean, boolean, Map, boolean, C, c) → Object
  - q6.s <init>(l3, String, String, r, a, boolean, Map, q, boolean, C, String)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40529 │ 40532 │ +3 (+8 -5) 
  
  + Q6.s0 k: boolean
  + e8.h p: boolean
  + e8.h q: Object
  + e8.h r: v
  + e8.h s: int
  + q6.s m: boolean
  + q6.s n: C
  + q6.s o: String
  
  - e8.h p: Object
  - e8.h q: v
  - e8.h r: int
  - q6.s m: C
  - q6.s n: String

@toluo-stripe toluo-stripe merged commit 15e054b into master Feb 3, 2025
16 checks passed
@toluo-stripe toluo-stripe deleted the tolu/link/2fa_surpress_flag branch February 3, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants