Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way we bind confirmation definitions. #10058

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Feb 1, 2025

Summary

Uses binds rather than provides for confirmation definition dependency injection. The only real point of this is to make adding new params to the definitions only require one file to change, rather than 2.

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ -1 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -1 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19975 │ 19975 │ 0 (+0 -0) 
   types │  6193 │  6193 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17538 │ 17538 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │  uncompressed   │                     
──────────┬──────┼──────────┬──────┤                     
 size     │ diff │ size     │ diff │ path                
──────────┼──────┼──────────┼──────┼─────────────────────
 28.5 KiB │ -2 B │ 63.1 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼──────┼──────────┼──────┼─────────────────────
 29.7 KiB │ -1 B │ 64.3 KiB │  0 B │ (total)

@jaynewstrom-stripe
Copy link
Collaborator Author

@samer-stripe worth doing this for all of them? It allows us to not have to change 2 places if we need a new param.

@samer-stripe
Copy link
Collaborator

samer-stripe commented Feb 1, 2025

@jaynewstrom-stripe 100% agreed! Can make a task to update all of these

@jaynewstrom-stripe jaynewstrom-stripe changed the title POC, change the way we bind confirmation definitions. Change the way we bind confirmation definitions. Feb 1, 2025
@jaynewstrom-stripe
Copy link
Collaborator Author

Link inline and intent confirmation are a little trickier, probably still possible to do, but I skipped them.

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review February 1, 2025 21:56
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners February 1, 2025 21:56
@jaynewstrom-stripe jaynewstrom-stripe merged commit 3aa8e40 into master Feb 2, 2025
13 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/inject-def branch February 2, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants