Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate back to AddFirstPaymentMethod immediately after removing last PM #10107

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

amk-stripe
Copy link
Collaborator

@amk-stripe amk-stripe commented Feb 7, 2025

Summary

Navigate back to AddFirstPaymentMethod immediately after removing last PM

Motivation

Walk the store PQ bug: https://docs.google.com/document/d/1jAte_o-0Ifl6242HB-okkpeoOn_te-dmepN3VGgn9ls/edit?tab=t.0#bookmark=id.dj6xrfb3vqpr

Testing

  • Added tests
  • Modified tests
  • Manually verified

We already have a test that verifies that we navigate back to the AddFirstPaymentMethod screen: here. It didn't previously account for the fact that we were on SelectSavedPaymentMethods for a short time before navigating back to that screen, so there's no test updating to do for that logic.

Screenshots

Before:

removing.pms.-.before.mp4

After:

removing.pms.-.after.mp4

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.8 KiB │  90.8 KiB │ +5 B │   171 KiB │   171 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +5 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19975 │ 19975 │ 0 (+0 -0) 
   types │  6193 │  6193 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17538 │ 17538 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 28.6 KiB │ +8 B │  63.2 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.4 KiB │ -3 B │  63.1 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
   54 KiB │ +5 B │ 126.3 KiB │  0 B │ (total)


assertThat(customerStateHolder.paymentMethods.value).isEmpty()
}

calledDetach.ensureAllEventsConsumed()
}

@Test
fun `removePaymentMethodInEditScreen does not call pop when in embedded`() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we no longer have embedded-specific logic in SavedPaymentMethodMutator, so we no longer need embedded specific tests either.

@amk-stripe amk-stripe marked this pull request as ready for review February 7, 2025 19:14
@amk-stripe amk-stripe requested review from a team as code owners February 7, 2025 19:14
@jaynewstrom-stripe
Copy link
Collaborator

Does this work for vertical mode too?

@amk-stripe
Copy link
Collaborator Author

Does this work for vertical mode too?

No, I wasn't sure if we wanted to make this update for vertical mode or not. It would be really simple to make that change though. Happy to follow up with that!

@amk-stripe amk-stripe merged commit f6711d1 into master Feb 7, 2025
13 checks passed
@amk-stripe amk-stripe deleted the transition-immediately-to-add-card-screen branch February 7, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants