-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigate back to AddFirstPaymentMethod immediately after removing last PM #10107
Conversation
Diffuse output:
APK
|
|
||
assertThat(customerStateHolder.paymentMethods.value).isEmpty() | ||
} | ||
|
||
calledDetach.ensureAllEventsConsumed() | ||
} | ||
|
||
@Test | ||
fun `removePaymentMethodInEditScreen does not call pop when in embedded`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we no longer have embedded-specific logic in SavedPaymentMethodMutator, so we no longer need embedded specific tests either.
Does this work for vertical mode too? |
No, I wasn't sure if we wanted to make this update for vertical mode or not. It would be really simple to make that change though. Happy to follow up with that! |
Summary
Navigate back to AddFirstPaymentMethod immediately after removing last PM
Motivation
Walk the store PQ bug: https://docs.google.com/document/d/1jAte_o-0Ifl6242HB-okkpeoOn_te-dmepN3VGgn9ls/edit?tab=t.0#bookmark=id.dj6xrfb3vqpr
Testing
We already have a test that verifies that we navigate back to the AddFirstPaymentMethod screen: here. It didn't previously account for the fact that we were on SelectSavedPaymentMethods for a short time before navigating back to that screen, so there's no test updating to do for that logic.
Screenshots
Before:
removing.pms.-.before.mp4
After:
removing.pms.-.after.mp4