Fix regression in CardInputWidget styling #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `android:textSize` attribute in `card_input_widget.xml` was hardcoded in #1930, preventing styling of the `CardInputWidget`'s EditText fields. Introduce a base style `Stripe.Base.CardInputWidget.EditText`, and override it with `Stripe.CardInputWidget.EditText` to allow for user customization. For example, in your app's `style.xml`, if you add the following: ``` <style name="Stripe.CardInputWidget.EditText" parent="Stripe.Base.CardInputWidget.EditText"> <item name="android:textSize">22sp</item> <item name="android:textColor">@android:color/holo_blue_light</item> <item name="android:textColorHint">@android:color/holo_orange_light</item> </style> ``` Fixes #1997
markfi-stripe
approved these changes
Dec 24, 2019
stripe-ci
assigned mshafrir-stripe and unassigned yuki-stripe, chander-stripe, davidme-stripe and markfi-stripe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
android:textSizeattribute incard_input_widget.xmlwashardcoded in #1930, preventing styling of the
CardInputWidget'sEditText fields.
Introduce a base style
Stripe.Base.CardInputWidget.EditText, andoverride it with
Stripe.CardInputWidget.EditTextto allow foruser customization.
For example, in your app's
style.xml, if you add the following:Fixes #1997