Update CardInputWidget to use TextInputLayout #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
assigned csabol-stripe, chander-stripe, davidme-stripe and markfi-stripe
Motivation: `TextInputLayout` offers some accessibility benefits [0], and also allows adding helper text that is separate from hint text. This can be used to set a hint text of "Card Number" and helper text of "1234 1234 1234 1234". Summary: - Update `CardInputWidget` to apply layout logic to `TextInputLayout` instead of `StripeEditText` views. - Set `contentDescription` on `TextInputLayout` for accessibility/TalkBack - Remove invisible `TextView`s used for accessibility-only - Remove unnecessary `tools:importantForAccessibility` - Make `StripeEditText` extend `TextInputEditText` [1] [0] https://developer.android.com/reference/com/google/android/material/textfield/TextInputLayout [1] https://developer.android.com/reference/com/google/android/material/textfield/TextInputEditText Testing: Tested on real device with TalkBack enabled
mshafrir-stripe
force-pushed
the
ciw-text-layout
branch
from
7329d0e to
f2ee00b
Compare
chander-stripe
approved these changes
Jan 7, 2020
stripe-ci
assigned mshafrir-stripe and unassigned csabol-stripe, chander-stripe, davidme-stripe and markfi-stripe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TextInputLayoutoffers some accessibility benefits [0], and alsoallows adding helper text that is separate from hint text. This can
be used to set a hint text of "Card Number" and helper text of
"1234 1234 1234 1234".
Summary
CardInputWidgetto apply layout logic toTextInputLayoutinstead of
StripeEditTextviews.contentDescriptiononTextInputLayoutfor accessibility/TalkBackTextViews used for accessibility-onlytools:importantForAccessibilityStripeEditTextextendTextInputEditText[1][0] https://developer.android.com/reference/com/google/android/material/textfield/TextInputLayout
[1] https://developer.android.com/reference/com/google/android/material/textfield/TextInputEditText
Testing
Tested on real device with TalkBack enabled