Update 14-digit Diners Club formatting #2221
Merged
+298
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfi-stripe
approved these changes
Feb 26, 2020
mshafrir-stripe
force-pushed
the
dinersclub-14-spacing
branch
from
3e24d78 to
737d827
Compare
Summary - Move card number grouping and formating logic to `CardBrand` - Programatically generate `CardInputWidget#hiddenCardText` and update it whenever the `CardBrand` changes Motivation 14-digit Diners club formatting should be `XXXX XXXXXX XXXX`. Update formatting logic accordingly. Testing Add unit tests Manually verify
mshafrir-stripe
force-pushed
the
dinersclub-14-spacing
branch
from
737d827 to
e1f50f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CardBrandCardInputWidget#hiddenCardTextand updateit whenever the
CardBrandchangesMotivation
14-digit Diners club formatting should be
XXXX XXXXXX XXXX. Updateformatting logic accordingly.
Testing
Add unit tests
Manually verify