Add stripe account param to authenticate source #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,11 +42,20 @@ class KlarnaSourceActivity : AppCompatActivity() { | |||
| viewBinding.progressBar.visibility = View.VISIBLE | |||
| createKlarnaSource().observe(this, Observer { result -> | |||
| viewBinding.progressBar.visibility = View.INVISIBLE | |||
| val stripeAccount = viewBinding.stripeAccount.text | |||
There was a problem hiding this comment.
can move this inside is SourceViewModel.SourceResult.Success -> { block
also you can make it a one-liner:
stripeAccountId = viewBinding.stripeAccount.text.toString().takeIf {
it.isNotBlank()
}
There was a problem hiding this comment.
ah I knew there must be a way to do this. Still kinda wish they just had an optional monad but I totally get why they do it this way
…ID-247_authenticate_source
|
@mshafrir should I test this with the card auth activity as well? How do I get a card that needs authentication? |
…ROID-247_confirm_setup
…ID-247_authenticate_source
mshafrir-stripe
approved these changes
Apr 22, 2020
smaskell-stripe
changed the base branch from
smaskell/ANDROID-247_confirm_setup
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Tested manually with klarna. Have not yet tested with a card because I'm not sure how to create a card that requires authentication